On 11/29/2011 03:54 PM, Matt Wagner wrote:
On Tue, Nov 29, 2011 at 11:57:57AM -0500, Scott Seago wrote:
src/app/controllers/application_controller.rb | 7 ++++++ src/app/controllers/catalog_entries_controller.rb | 1 + src/app/controllers/deployables_controller.rb | 25 +++++++++++++++++++++ src/app/controllers/permissions_controller.rb | 5 ++- src/app/views/catalog_entries/show.html.haml | 8 ++++-- src/app/views/permissions/_permissions.html.haml | 7 +++-- src/config/routes.rb | 2 + src/features/catalog_entries.feature | 2 +- 8 files changed, 48 insertions(+), 9 deletions(-) create mode 100644 src/app/controllers/deployables_controller.rb
ACK.
I had two nits, but it turns out that neither is related to your patch. I'm mentioning them here anyway before going to look at them, but neither seems to be caused by your patch, so push away.
Both are incidentally shown in this screenshot: http://lts.cr/BKoD
The first is that the flash message is ultra-confusing: "These User Roles were modified: admin Deployable User from Deployable Owner"
It's not necessarily incorrect, it's just that mechnanically stringing together various fragments results in something that's confusing in English and might make even less sense upon translation.
The other is that the "Launch" button is all messed up, in both Chrome and Firefox.
But again, these aren't actually caused by your patch, so ACK. I'm going to take a quick gander at fixing these two tangential nits now...
-- Matt
Pushed the patch.
Scott