aeolus-devel September 2011

aeolus-devel@lists.fedorahosted.org

47 participants
201 discussions

Re: [PATCH] BZ#741388 Adding directions to install aeolus-conductor-devel
by Chris Lalancette 27 Sep '11

27 Sep '11

On 09/26/11 - 06:03:02PM, Christopher Alfonso wrote: > > > On Sep 26, 2011, at 4:31 PM, Chris Lalancette <clalance(a)redhat.com> wrote: > > > On 09/26/11 - 01:30:47PM, Chris Alfonso wrote: > >> rubygem-rspec is installed by aeolus-conductor-devel, which is required > >> before rake tasks can be run. I've added documentation to the README > >> to direct the user to install the aeolus-conductor-devel package before > >> running rake rpms. > >> --- > >> README | 4 ++-- > >> 1 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/README b/README > >> index 1a596ff..e96cf2b 100644 > >> --- a/README > >> +++ b/README > >> @@ -12,8 +12,8 @@ to install and configure aeolus components. To make use > >> of this recipe, drop it into your puppet module path or > >> alternatively build and install the aeolus-configure rpm > >> which contains the recipe and some wrapper scripts to configure > >> -the aeolus components. > >> - > >> +the aeolus components. Before executing the rake rpms task, you > >> +will need to install the aeolus-conductor-devel package. > > > > That seems a bit...self-referential. I would change this to just reference > > the package directly: > > > > "Before executing the rake rpms task, will need to install the rspec gem" > > > > I thought about that, but I think that will require us to update the readme each time we add a dependency to the Rakefile. From what I gathered, we expect developers to install the devel package as a prerequisite to building. Since the configure project doesn't have the aeolus-conductor-devel spec, I didn't see it as self-referential. Agree/Disagree? Ah, I missed it was for configure and not conductor. In any case, I think I would still reference the package directly. We shouldn't be adding new dependencies to the Rakefile often; if we do, that is a sign that we are adding too many dependencies. -- Chris Lalancette

2 1

[PATCH configure] BZ#741388 Adding directions to install
by Chris Alfonso 26 Sep '11

26 Sep '11

rubygem-rspec is installed by aeolus-conductor-devel, which is required before rake tasks can be run. I've added documentation to the README to direct the user to install the aeolus-conductor-devel package before running rake rpms.

2 2

cloudsh - a single command to deploy, migrate, etc cloud instances
by Mo Morsi 26 Sep '11

26 Sep '11

Am continuing to work on a single unified command to leverage aeolus to perform many cloud operations in a high level manner. This is the command line interface analogous to the conductor web interface This was originally intended to go into the interactive installer in configure [1], but it really doesn't belong there. I've uploaded the initial codebase to my github account [2]. The end user simply needs to $ sudo yum install cloudsh (the only command that requires super user access) # configure providers on a system wide basis via /etc/cloud.yml or on an individual user basis via ~/.cloud.yml # deploy a new instance to a cloud $ /usr/bin/cloudsh --deploy --cloud ec2 --os fedora.15.x86_64 --repo http://my.custom.yum.repo --package mediawiki --package wordpress # migrate an instance from on cloud to another $ /usr/bin/cloudsh --migrate --from-cloud ec2 --to-cloud rhev --instance my.custom.instance.id # scale instance across clouds $ /usr/bin/cloudsh --scale --from-cloud rackspace --to-cloud rhev --instance another.instance Still a work in progress. Stay tuned for more updates, -Mo [1] https://fedorahosted.org/pipermail/aeolus-devel/2011-September/004821.html [2] http://github.com/movitto/cloudsh

2 1

[PATCH aeolus-website 0/1] Update news on website
by Matt Wagner 26 Sep '11

26 Sep '11

This patch updates news.html to link to our accounts on Twitter, Identi.ca, and Youtube. It also has a second news blurb for the presentation lutter gave at Puppetconf with a link to the slides. The homepage is also updated to include these news blurbs. We should probably think about using a CMS some day...

2 2

[PATCH conductor] Instance key may be nil for non ec2 and mock providers
by Richard Su 26 Sep '11

26 Sep '11

This would be the case for rhev and vpshere. --- src/app/util/taskomatic.rb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/app/util/taskomatic.rb b/src/app/util/taskomatic.rb index 84dabd0..155abe6 100644 --- a/src/app/util/taskomatic.rb +++ b/src/app/util/taskomatic.rb @@ -157,7 +157,7 @@ module Taskomatic :hwp_cpu => overrides[:cpu], :hwp_storage => overrides[:storage], :realm_id => (match.realm.external_key rescue nil), - :keyname => (instance.instance_key.name)) + :keyname => (instance.instance_key.name rescue nil)) end def self.matches(instance) -- 1.7.6.2

3 4

Problem with new Admin UI stylesheets
by Jirka Tomasek 26 Sep '11

26 Sep '11

If you pull latest Admin UI changes from master you will probably need to recompile stylesheets because the compiled stylesheets are in .gitignore. From src folder run sass --watch app/stylesheets:public/stylesheets/compiled There are also a few bugs in Cloud Providers section which I am working on to get fixed. Jirka

1 0

[PATCH conductor] BZ#740939 Rename button-to css class to button_to, aligns
by Chris Alfonso 26 Sep '11

26 Sep '11

https://bugzilla.redhat.com/show_bug.cgi?id=740939 Rails button-to ActionView::HelperUrlHelper has a method called button_to. The button_to method automatically renders a style class on the element called button_to. This patch changes the stylesheet class name to button_to. This patch has been pushed to master as it's a very minor css change.

1 1

[PATCH conductor] Added permissions checking when listing hw profiles
by Jan Provazník 26 Sep '11

26 Sep '11

From: Jan Provaznik <jprovazn(a)redhat.com> BZ 739912 https://www.aeolusproject.org/redmine/issues/2386 --- .../controllers/hardware_profiles_controller.rb | 12 ++++---- .../hardware_profiles_controller_spec.rb | 28 +++++++++++++------ 2 files changed, 25 insertions(+), 15 deletions(-) diff --git a/src/app/controllers/hardware_profiles_controller.rb b/src/app/controllers/hardware_profiles_controller.rb index 2463697..0e7249d 100644 --- a/src/app/controllers/hardware_profiles_controller.rb +++ b/src/app/controllers/hardware_profiles_controller.rb @@ -33,7 +33,7 @@ class HardwareProfilesController < ApplicationController save_breadcrumb(hardware_profiles_path) @params = params respond_to do |format| - format.html { load_hardware_profiles } + format.html format.js do build_hardware_profile(params[:hardware_profile]) matching_provider_hardware_profiles @@ -213,13 +213,13 @@ class HardwareProfilesController < ApplicationController end def load_hardware_profiles - sort_field = params[:order_field].nil? ? "name" : params[:order_field] - sort_order = params[:order_dir] == "asc" || params[:order_dir].nil? ? "" : "desc" + sort_field = params[:order_field].blank? ? "name" : params[:order_field] + sort_order = params[:order_dir].to_s == "desc" ? "desc" : "asc" if sort_field == "name" - @hardware_profiles = HardwareProfile.all(:order => sort_field + " " + sort_order, :conditions => 'provider_id IS NULL') + @hardware_profiles = HardwareProfile.list_for_user(current_user, Privilege::VIEW, :order => "hardware_profiles.name #{sort_order}", :conditions => ['provider_id IS NULL', {}]) else - @hardware_profiles = HardwareProfile.all(:conditions => 'provider_id IS NULL') - if sort_order == "" + @hardware_profiles = HardwareProfile.list_for_user(current_user, Privilege::VIEW, :conditions => ['provider_id IS NULL', {}]) + if sort_order == "asc" @hardware_profiles.sort! {|x,y| x.get_property_map[sort_field].sort_value(true) <=> y.get_property_map[sort_field].sort_value(true)} else @hardware_profiles.sort! {|x,y| y.get_property_map[sort_field].sort_value(false) <=> x.get_property_map[sort_field].sort_value(false)} diff --git a/src/spec/controllers/hardware_profiles_controller_spec.rb b/src/spec/controllers/hardware_profiles_controller_spec.rb index ef2db46..cd5cb6d 100644 --- a/src/spec/controllers/hardware_profiles_controller_spec.rb +++ b/src/spec/controllers/hardware_profiles_controller_spec.rb @@ -26,18 +26,18 @@ describe HardwareProfilesController do @admin = @admin_permission.user end - it "should provide ui to view all hardware profiles" do - mock_warden(@admin) - @request.accept = "text/html" - get :index - response.should be_success - assigns[:hardware_profiles].size.should == HardwareProfile.count - response.should render_template("index") - end - describe "Authorization" do context "Admin" do + it "should provide ui to view all hardware profiles" do + mock_warden(@admin) + @request.accept = "text/html" + get :index + response.should be_success + assigns[:hardware_profiles].size.should == HardwareProfile.count + response.should render_template("index") + end + it "should be able to create hardware profiles" do mock_warden(@admin) lambda do @@ -86,6 +86,16 @@ describe HardwareProfilesController do @user = @user_permission.user end + it "should not list hw profiles which I'm not allowed to see" do + hardware_profile = Factory.create :hardware_profile + mock_warden(@user) + @request.accept = "text/html" + get :index + response.should be_success + assigns[:hardware_profiles].find {|p| p.name == hardware_profile.name}.should be_nil + response.should render_template("index") + end + it "should not be able to create hardware profiles" do mock_warden(@user) lambda do -- 1.7.6

2 1

[PATCH conductor] BZ#740939 Rename button-to css class to button_to, aligns
by Chris.Alfonso＠redhat.com 26 Sep '11

26 Sep '11

https://bugzilla.redhat.com/show_bug.cgi?id=740939 Rails button-to ActionView::HelperUrlHelper has a method called button_to. The button_to method automatically renders a style class on the element called button_to. This patch changes the stylesheet class name to button_to. I already pushed this patch to master since it's so trivial.

1 1

[PATCH 0/12] New Admin UI
by Jirka Tomasek 26 Sep '11

26 Sep '11

This patchset implements all nessesary changes to merge admin_ui branch to master. Cloud Providers section is complete, realms and hardware profile tabs under Provider shows list of related realms/hwp's, the routes for realms and hwp's remained the same to enable direct listing for now. Users and Groups section has Users implemented. All other sections have adapted new admin ui style and work. This patchset implements redmine #2333, 2384, 2378 and 2236

2 14

← Newer
1
2
3
4
5
6
7
8
...
21
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

aeolus-devel September 2011