This patch fixes BZ713720 and right scrollbar appearing all the time. I am sending the corrections made to layout.scss, which is generated, so if I should do the changes to aeolus-uxdev, let me know. If we support IE6 then there should be
#primary-container { height: 100%; }
added to IE6 specific stylesheet.
From: Jiri Tomasek jtomasek@redhat.com
--- src/app/stylesheets/layout.scss | 9 +++++++-- src/app/views/layouts/application.haml | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/app/stylesheets/layout.scss b/src/app/stylesheets/layout.scss index 18fff1c..a207bef 100644 --- a/src/app/stylesheets/layout.scss +++ b/src/app/stylesheets/layout.scss @@ -663,7 +663,7 @@ $contentpadding: 7px; div#content{ width: $width - (2 * $contentpadding); margin: 0 auto; - margin-bottom: 98px; + margin-bottom: 58px; min-height: 200px; -webkit-border-radius: 7px; -moz-border-radius: 7px; border-radius: 7px; background-color: #FAFAFA; @@ -2336,6 +2336,11 @@ Page Footer -- v.0.0.1 [footer] (footer.scss)
/* Footer */
+.clearfooter{ + height: 40px; + clear: both; +} + footer.standard{
background: rgba(0, 0, 0, 0.20); @@ -2364,7 +2369,7 @@ footer.standard{
nav.footer{ display: inline-block; - padding: 14px; + padding: 14px 14px 13px 14px; a{ color: #fff; padding-right: 6px; diff --git a/src/app/views/layouts/application.haml b/src/app/views/layouts/application.haml index 044d9e0..c943ef3 100644 --- a/src/app/views/layouts/application.haml +++ b/src/app/views/layouts/application.haml @@ -42,7 +42,7 @@ -# works with any 960 container (.container_16 or .container_24) = render :partial => 'layouts/nav_history' = yield - + .clearfooter %footer.standard .container = image_tag('footer-rhlogo.png', :id => 'logo')
The layout.css file is auto-generated by the uxd tool and should remain so for now to reduce headaches. I know this has already been ACKed and pushed, but in the future, you should submit a patch for the UXdev repo, or simply put the patch in another file. I will manually merge these changes into UXdev in the appropriate places.
Otherwise, nice work!
Cheers, Ken Keiter (tigger)
On Jun 23, 2011, at 1:30 AM, jtomasek@redhat.com wrote:
From: Jiri Tomasek jtomasek@redhat.com
src/app/stylesheets/layout.scss | 9 +++++++-- src/app/views/layouts/application.haml | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/app/stylesheets/layout.scss b/src/app/stylesheets/layout.scss index 18fff1c..a207bef 100644 --- a/src/app/stylesheets/layout.scss +++ b/src/app/stylesheets/layout.scss @@ -663,7 +663,7 @@ $contentpadding: 7px; div#content{ width: $width - (2 * $contentpadding); margin: 0 auto;
- margin-bottom: 98px;
- margin-bottom: 58px; min-height: 200px; -webkit-border-radius: 7px; -moz-border-radius: 7px; border-radius: 7px; background-color: #FAFAFA;
@@ -2336,6 +2336,11 @@ Page Footer -- v.0.0.1 [footer] (footer.scss)
/* Footer */
+.clearfooter{
- height: 40px;
- clear: both;
+}
footer.standard{
background: rgba(0, 0, 0, 0.20); @@ -2364,7 +2369,7 @@ footer.standard{
nav.footer{ display: inline-block;
- padding: 14px;
- padding: 14px 14px 13px 14px; a{ color: #fff; padding-right: 6px;
diff --git a/src/app/views/layouts/application.haml b/src/app/views/layouts/application.haml index 044d9e0..c943ef3 100644 --- a/src/app/views/layouts/application.haml +++ b/src/app/views/layouts/application.haml @@ -42,7 +42,7 @@ -# works with any 960 container (.container_16 or .container_24) = render :partial => 'layouts/nav_history' = yield
%footer.standard .container = image_tag('footer-rhlogo.png', :id => 'logo').clearfooter
-- 1.7.4.2
On 06/23/2011 05:43 PM, Kenneth Keiter wrote:
The layout.css file is auto-generated by the uxd tool and should remain so for now to reduce headaches. I know this has already been ACKed and pushed, but in the future, you should submit a patch for the UXdev repo, or simply put the patch in another file. I will manually merge these changes into UXdev in the appropriate places.
Otherwise, nice work!
Cheers, Ken Keiter (tigger)
For the record, we have the file `custom.scss` precisely for this purpose -- tweaks created by hand that should not get overwritten by the uxd tool.
Thomas
Dne 23.6.2011 18:01, Tomas Sedovic napsal(a):
On 06/23/2011 05:43 PM, Kenneth Keiter wrote:
The layout.css file is auto-generated by the uxd tool and should remain so for now to reduce headaches. I know this has already been ACKed and pushed, but in the future, you should submit a patch for the UXdev repo, or simply put the patch in another file. I will manually merge these changes into UXdev in the appropriate places.
Otherwise, nice work!
Cheers, Ken Keiter (tigger)
For the record, we have the file `custom.scss` precisely for this purpose -- tweaks created by hand that should not get overwritten by the uxd tool.
Thomas
As far as I know the patch has not yet been pushed.
I wanted to make changes to aeolus_uxdev so its easier for everyone to track the changes in layout, but it seems that the generated aeolus_uxdev layout.scss and layout.scss in aeolus are not in sync (even in aeolus_uxdev its older). It would be good to keep aeolus_uxdev up to date, so we can generate layout.scss anytime and put it into aeolus to promote changes. So the workflow with the layout is:
1. changes in layout are made as patch for aeolus_uxdev and sent to list 2. Ken acks the patch and pushes it to aeolus_uxdev 3. generated layout.scss reflects the latest changes and it is always possible to be put in aeolus.
Jirka
aeolus-devel@lists.fedorahosted.org