ldap/servers/slapd/pw.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 393a939fe8e33c4d9cedf3b3b6f7b0757f081a4f
Author: Noriko Hosoi <nhosoi(a)redhat.com>
Date: Mon Mar 2 11:12:11 2015 -0800
Ticket #48048 - Fix coverity issues - 2015/3/1
Coverity defect 13034 - Explicit null dereferenced (FORWARD_NULL)
Description: Added NULL check for operation and sdn.
modified: update_pw_info in pw.c
https://fedorahosted.org/389/ticket/48048
Reviewed by rmeggins(a)redhat.com (Thank you, Rich!!)
(cherry picked from commit f6eeaf93ff608e1381063155afa9acea6c3d8045)
diff --git a/ldap/servers/slapd/pw.c b/ldap/servers/slapd/pw.c
index b5a75d9..3e2dd90 100644
--- a/ldap/servers/slapd/pw.c
+++ b/ldap/servers/slapd/pw.c
@@ -636,8 +636,9 @@ update_pw_info ( Slapi_PBlock *pb , char *old_pw)
slapi_pblock_get( pb, SLAPI_TARGET_SDN, &sdn );
slapi_pblock_get( pb, SLAPI_REQUESTOR_NDN, &bind_dn);
slapi_pblock_get( pb, SLAPI_ENTRY_PRE_OP, &e);
- if (NULL == e) {
- slapi_log_error(SLAPI_LOG_FATAL, "pwdpolicy", "update_pw_info: no
password entry \n");
+ if ((NULL == operation) || (NULL == sdn) || (NULL == e)){
+ slapi_log_error(SLAPI_LOG_FATAL, "pwdpolicy",
+ "update_pw_info: param error - no password entry/target
dn/operation\n");
return -1;
}
internal_op = slapi_operation_is_flag_set(operation, SLAPI_OP_FLAG_INTERNAL);