This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.1
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.1 by this push:
new 62432a2 Ticket 50727 - change syntax validate by default in 1.4.2
62432a2 is described below
commit 62432a29d44eddfe5109e24cb3d2d22cbd7268b7
Author: William Brown <william(a)blackhats.net.au>
AuthorDate: Wed Dec 18 13:14:24 2019 +1000
Ticket 50727 - change syntax validate by default in 1.4.2
Bug Description: The default syntax validate for 1.4.2 should be changed to
a softer introduction so that admins have time to prepare for the change
of query behaviour in 1.4.3.
Fix Description: Change default in 1.4.2 to warn-invalid, 1.4.3 will
remain as process-safe.
https://pagure.io/389-ds-base/issue/50727
Author: William Brown <william(a)blackhats.net.au>
Review by: tbordaz (Thanks)
---
ldap/servers/slapd/libglobs.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/ldap/servers/slapd/libglobs.c b/ldap/servers/slapd/libglobs.c
index 167a3fe..5c8966d 100644
--- a/ldap/servers/slapd/libglobs.c
+++ b/ldap/servers/slapd/libglobs.c
@@ -1773,7 +1773,7 @@ FrontendConfig_init(void)
* scheme set in cn=config
*/
init_enable_upgrade_hash = cfg->enable_upgrade_hash = LDAP_ON;
- init_verify_filter_schema = cfg->verify_filter_schema = SLAPI_WARN;
+ init_verify_filter_schema = cfg->verify_filter_schema = SLAPI_WARN_UNSAFE;
/* Done, unlock! */
CFG_UNLOCK_WRITE(cfg);
@@ -7679,8 +7679,7 @@ config_set_onoffwarn(slapdFrontendConfig_t *slapdFrontendConfig,
slapi_onwarnoff
return LDAP_OPERATIONS_ERROR;
}
- slapi_onwarnoff_t p_val = SLAPI_OFF;
-
+ slapi_special_filter_verify_t p_val = SLAPI_WARN_UNSAFE;
if (strcasecmp(value, "on") == 0) {
p_val = SLAPI_ON;
} else if (strcasecmp(value, "warn") == 0) {
@@ -8023,8 +8022,8 @@ config_set_value(
} else if (*((slapi_onwarnoff_t *)value) == SLAPI_WARN) {
slapi_entry_attr_set_charptr(e, cgas->attr_name, "warn");
} else {
- slapi_entry_attr_set_charptr(e, cgas->attr_name, "off");
- /* Default to off. */
+ /* Default to safe warn-proccess-safely */
+ slapi_entry_attr_set_charptr(e, cgas->attr_name,
"warn-invalid");
}
break;
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.