[SSSD] [PATCH] Return error code from ipa_subdom_store

Sumit Bose sbose at redhat.com
Tue Mar 5 08:57:36 UTC 2013


On Tue, Mar 05, 2013 at 12:20:12AM +0100, Jakub Hrozek wrote:
> I don't think there is a reason to ignore error codes while storing
> subdomains.

I see it the other way round, there is no reason to return an error if
storing a subdomain fails, because we cannot do anything about it. If an
error is returned here, the operation which triggered to subdomain
lookup, e.g. getpwnam() with a fully qualified name, will fail. But the
needed subdomain for this request might already be stored by a previous
sysdb_subdomain_store() call, so if we return EOK the request might
finish successfully.

For this reasons I prefer to ignore the error. But if you think it would
be better that the original request fails so that the error is not
unnoticed I wouldn't be against it.

bye,
Sumit

> From de913e37e2e9a379e8e323f758e139cc610aff59 Mon Sep 17 00:00:00 2001
> From: Jakub Hrozek <jhrozek at redhat.com>
> Date: Tue, 5 Mar 2013 00:15:35 +0100
> Subject: [PATCH] Return error code from ipa_subdom_store
> 
> ---
>  src/providers/ipa/ipa_subdomains.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/providers/ipa/ipa_subdomains.c b/src/providers/ipa/ipa_subdomains.c
> index 7d6e5958ed1e8ff9ea663c9e3bc754442a46f3c6..29ebd1fed1dec8b58119c4251c15c7d070a91fd8 100644
> --- a/src/providers/ipa/ipa_subdomains.c
> +++ b/src/providers/ipa/ipa_subdomains.c
> @@ -230,11 +230,13 @@ static errno_t ipa_subdom_store(struct sss_domain_info *domain,
>      ret = sysdb_subdomain_store(domain->sysdb, name, realm, flat, id);
>      if (ret) {
>          DEBUG(SSSDBG_OP_FAILURE, ("sysdb_subdomain_store failed.\n"));
> +        goto done;
>      }
>  
> +    ret = EOK;
>  done:
>      talloc_free(tmp_ctx);
> -    return EOK;
> +    return ret;
>  }
>  
>  static errno_t
> -- 
> 1.8.1.4
> 

> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel




More information about the sssd-devel mailing list