[SSSD] [PATCH] Return error code from ipa_subdom_store

Jakub Hrozek jhrozek at redhat.com
Mon Mar 4 23:20:12 UTC 2013


I don't think there is a reason to ignore error codes while storing
subdomains.
-------------- next part --------------
>From de913e37e2e9a379e8e323f758e139cc610aff59 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Tue, 5 Mar 2013 00:15:35 +0100
Subject: [PATCH] Return error code from ipa_subdom_store

---
 src/providers/ipa/ipa_subdomains.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/providers/ipa/ipa_subdomains.c b/src/providers/ipa/ipa_subdomains.c
index 7d6e5958ed1e8ff9ea663c9e3bc754442a46f3c6..29ebd1fed1dec8b58119c4251c15c7d070a91fd8 100644
--- a/src/providers/ipa/ipa_subdomains.c
+++ b/src/providers/ipa/ipa_subdomains.c
@@ -230,11 +230,13 @@ static errno_t ipa_subdom_store(struct sss_domain_info *domain,
     ret = sysdb_subdomain_store(domain->sysdb, name, realm, flat, id);
     if (ret) {
         DEBUG(SSSDBG_OP_FAILURE, ("sysdb_subdomain_store failed.\n"));
+        goto done;
     }
 
+    ret = EOK;
 done:
     talloc_free(tmp_ctx);
-    return EOK;
+    return ret;
 }
 
 static errno_t
-- 
1.8.1.4



More information about the sssd-devel mailing list