Change in vdsm[master]: net: fake OVS networks as bridgeless
phoracek at redhat.com
phoracek at redhat.com
Fri May 13 10:19:31 UTC 2016
Petr Horáček has posted comments on this change.
Change subject: net: fake OVS networks as bridgeless
......................................................................
Patch Set 6: Verified+1
(3 comments)
Passed ovs_info_test.py
https://gerrit.ovirt.org/#/c/57068/5/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:
PS5, Line 289:
> Lets drop it and make it clear below that we change netinfo.
Done
PS5, Line 291: def _ovs_networks(networks):
: return ((net, attrs) for net, attrs in six.iter
> Please avoid it and make sure the caller supplies it.
Done
PS5, Line 299:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
> How about this?
Done
--
To view, visit https://gerrit.ovirt.org/57068
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list