Change in vdsm[master]: storage: Do not reference image dir in backing volume path

nsoffer at redhat.com nsoffer at redhat.com
Fri May 13 07:13:42 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: storage: Do not reference image dir in backing volume path
......................................................................


storage: Do not reference image dir in backing volume path

Until now, the backing volume path (to be written into qcow2 metadata)
was computed as ../<imgUUID>/<volUUID>.  The ../<imgUUID> component
causes the backing_chain field of volumes to grow every time a live
merge is performed until it eventually overflows.  The blockSD function
createImageLinks is now ensuring that all volumes of an image (including
templates) are in a directory together so we can use just the volume ID
to reference the backing volume.  File domains hard link templates into
the directories of images that are dependent so this works for file
domains as well.

Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1333627
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/57284
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/storage/volume.py
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/57284
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list