Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

igoihman at redhat.com igoihman at redhat.com
Thu May 12 19:17:18 UTC 2016


Irit Goihman has posted comments on this change.

Change subject: Makefile: use tox to run make pep8 and pyflakes
......................................................................


Patch Set 14:

> with this patch, we require el7 developers and builders to install
 > tox by pip.
 > 
 > Can we somehow avoid that? If not, we have to make sure we do not
 > harm d/s builds, and we should update our website, and place a
 > clear warning on the commit message.

tox version in el7 is very old and has a strange behavior. We have to install by pip in order to get the newer version. I was planning to update the website once the patch will be merged.

-- 
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list