Change in vdsm[master]: hostdev: teardown non-scsi devices

fromani at redhat.com fromani at redhat.com
Thu May 12 15:08:08 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: hostdev: teardown non-scsi devices
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/57375/4/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

PS4, Line 48:     def teardown(self):
            :         if CAPABILITY_TO_XML_ATTR[self._deviceParams['capability']] != 'pci':
            :             reattach_detachable(self.device)
so we trust device drivers for usb and scsi after all :)
Makes sense, both are hotplug-capable even on consumer-grade hardware (not really sure about consumer-grade scsi, though)

But how hard is to fix the permission without all the full reattach_detachable dance?


-- 
To view, visit https://gerrit.ovirt.org/57375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc8b8780203fcd29afa37dabc4594e2767245359
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list