Change in vdsm[master]: virt: add kernel cmdline reporting

mpolednik at redhat.com mpolednik at redhat.com
Thu May 12 13:51:57 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/57084/7/vdsm/caps.py
File vdsm/caps.py:

Line 175: 
Line 176:     caps['operatingSystem'] = osinfo.version()
Line 177:     caps['uuid'] = host.uuid()
Line 178:     caps['packages2'] = osinfo.package_versions()
Line 179:     caps['kernelArgs'] = osinfo.kernel_args('/proc/cmdline')
> IMHO nicer with the default argument
True, fixed.
Line 180:     caps['emulatedMachines'] = machinetype.emulated_machines(
Line 181:         cpuarch.effective())
Line 182:     caps['ISCSIInitiatorName'] = _getIscsiIniName()
Line 183:     caps['HBAInventory'] = storage.hba.HBAInventory()


-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list