Change in vdsm[master]: hostdev: fix scsi udev rule target

fromani at redhat.com fromani at redhat.com
Thu May 12 13:47:46 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
......................................................................


Patch Set 4:

(1 comment)

same question as PS3

https://gerrit.ovirt.org/#/c/57373/4/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

PS4, Line 63: udev_path.split('/', 2)[2]
For my understanding:
1. this should never raise
2. if it raises, it is better for us to explode here
right?

Also, could you please remind me how udev_path looks like?


-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list