Change in vdsm[master]: hostdev: fix udev rule target

mpolednik at redhat.com mpolednik at redhat.com
Thu May 12 13:22:28 UTC 2016


Martin Polednik has uploaded a new change for review.

Change subject: hostdev: fix udev rule target
......................................................................

hostdev: fix udev rule target

Previously, the rule worked as expected but did not properly signal
ownership of the device. That is now fixed with kernel and subsystem
targets.

Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Signed-off-by: Martin Polednik <mpolednik at redhat.com>
---
M vdsm/supervdsm_api/udev.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/57373/1

diff --git a/vdsm/supervdsm_api/udev.py b/vdsm/supervdsm_api/udev.py
index cbeb133..980fee0 100644
--- a/vdsm/supervdsm_api/udev.py
+++ b/vdsm/supervdsm_api/udev.py
@@ -59,8 +59,9 @@
 @expose
 def appropriateSCSIDevice(device_name, udev_path):
     ruleFile = _UDEV_RULE_FILE_NAME % ('scsi', device_name)
-    rule = 'RUN+="%s %s:%s %s"\n' % (
-        EXT_CHOWN, QEMU_PROCESS_USER, QEMU_PROCESS_GROUP, udev_path)
+    rule = 'KERNEL=="%s" SUBYSTEM=="scsi_generic" RUN+="%s %s:%s %s"\n' % (
+        udev_path.split('/', 2)[2], EXT_CHOWN, QEMU_PROCESS_USER,
+        QEMU_PROCESS_GROUP, udev_path)
     with open(ruleFile, "w") as rf:
         _log.debug("Creating rule %s: %r", ruleFile, rule)
         rf.write(rule)


-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>


More information about the vdsm-patches mailing list