Change in vdsm[master]: net: OVS netinfo
phoracek at redhat.com
phoracek at redhat.com
Wed May 11 14:33:36 UTC 2016
Petr Horáček has posted comments on this change.
Change subject: net: OVS netinfo
......................................................................
Patch Set 32: Verified+1
(3 comments)
Passed ovs_info_test.py
https://gerrit.ovirt.org/#/c/56972/31/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:
Line 137:
Line 138: southbound = ovs_info.southbound_port(ports)
Line 139:
Line 140: # northbound ports represents networks
Line 141: stp = bridge_attrs['stp']
> Interesting.. This means that STP can can be set only per OVS bridge? Can't
Added note to trello.
Line 142: for northbound_port in ovs_info.northbound_ports(ports):
Line 143: _netinfo['networks'][northbound_port] = _get_network_info(
Line 144: northbound_port, bridge, southbound, ports, stp, addresses,
Line 145: routes)
PS31, Line 174: ports(bridge, northbound,
> This tag is hunting me now... it is already resolved at the caller.
Done
PS31, Line 188: bond_attrs)
> Seems that we need only bond_attrs as an argument.
Done
--
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list