Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

mpolednik at redhat.com mpolednik at redhat.com
Wed May 11 10:19:07 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: migration: Enable lazy setting of incoming/outgoing limits
......................................................................


Patch Set 32: Code-Review-1

(3 comments)

Initial review, mostly wording issues.

https://gerrit.ovirt.org/#/c/53305/32//COMMIT_MSG
Commit Message:

PS32, Line 7: lazy
There is nothing lazy about the functionality.


https://gerrit.ovirt.org/#/c/53305/32/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS32, Line 2915: defaultvalue: null
(+ below) are these really null? Contradicts statement that the value must be > 0.


https://gerrit.ovirt.org/#/c/53305/32/vdsm/API.py
File vdsm/API.py:

PS32, Line 585: Must be > 0.
Seeing the code below, this really is a lie. None, 0 and {} (or whatever) are totally fine.


-- 
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list