Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits
fromani at redhat.com
fromani at redhat.com
Wed May 11 09:36:56 UTC 2016
Francesco Romani has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
......................................................................
Patch Set 31:
(2 comments)
https://gerrit.ovirt.org/#/c/53305/31/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line 2913: type: boolean
Line 2914:
Line 2915: - defaultvalue: null
Line 2916: description: maximum number of outgoing migrations
Line 2917: Must be > 0, values <= 0 are silently ignored.
> Negative values are not silently ignored. But we declare `type: uint' here
right, excessive copy-paste.
Line 2918: name: outgoingLimit
Line 2919: type: uint
Line 2920: added: '4.0'
Line 2921:
https://gerrit.ovirt.org/#/c/53305/31/vdsm/API.py
File vdsm/API.py:
Line 585: :type params: dict
Line 586: :param incomingLimit: maximum number of incoming migrations to set
Line 587: before the migration is started.
Line 588: Must be > 0, values <= 0 are silently ignored.
Line 589: :type incomingLimit: int
> uint, not int
this is supposed to be a python type.
Line 590: """
Line 591: self.log.debug('Migration create')
Line 592:
Line 593: if incomingLimit:
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list