Change in vdsm[master]: net: OVS Info

edwardh at redhat.com edwardh at redhat.com
Tue May 10 20:12:12 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: OVS Info
......................................................................


Patch Set 30:

(1 comment)

https://gerrit.ovirt.org/#/c/56901/30/lib/vdsm/network/ovs/driver/vsctl.py
File lib/vdsm/network/ovs/driver/vsctl.py:

Line 179:         if_cmd = ['--id=@%s' % id, 'create', 'Interface', 'name=%s' % slave]
Line 180:         port_cmd = ['add', 'Port', bond, 'interfaces', '@%s' % id]
Line 181:         return Command(if_cmd), Command(port_cmd)
Line 182: 
Line 183:     def detach_bond_slave(self, bond, slave):
> It's validated by us. We have to allow that on this level - we have to firs
Sounds right, so we should have a validator check when modifying bonds.
Line 184:         id = uuid.uuid4()
Line 185:         if_cmd = ['--id=@%s' % id, 'get', 'Interface', slave]
Line 186:         port_cmd = ['remove', 'Port', bond, 'interfaces', '@%s' % id]
Line 187:         return Command(if_cmd), Command(port_cmd)


-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list