Change in vdsm[master]: sp: race in domains upgrade prevents further pool upgrades

laravot at redhat.com laravot at redhat.com
Tue May 10 15:57:23 UTC 2016


Liron Aravot has posted comments on this change.

Change subject: sp: race in domains upgrade prevents further pool upgrades
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/57315/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 460
Line 461
Line 462
Line 463
Line 464
> can you just put the [:] here without storing the local variable domainsToU
having it here is problematic, because the domain monitor callback is registered in line 461 so an element could be removed during the copy of the list if its done here


-- 
To view, visit https://gerrit.ovirt.org/57315
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie384c63315214786dc62f2b4998002320e314d30
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list