Change in vdsm[master]: rpc: Make Bridge#_type_fixup more robust

danken at redhat.com danken at redhat.com
Tue May 10 14:01:41 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: rpc: Make Bridge#_type_fixup more robust
......................................................................


rpc: Make Bridge#_type_fixup more robust

_type_fixup method assumed that all top-level arguments of rpc calls are
dictionaries thus failing with arguments of type e.g. 'int'.

This patch fixes this issues and only recurses deeper if the 'item'
itself is a dictionary.

Change-Id: I5871f6c08fe384f52bfa190a44290e2489f06981
Signed-off-by: Martin Betak <mbetak at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/56811
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M lib/vdsm/rpc/Bridge.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Martin Betak: Verified
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56811
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5871f6c08fe384f52bfa190a44290e2489f06981
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list