Change in vdsm[master]: bridge: usage of yaml schema

danken at redhat.com danken at redhat.com
Tue May 10 12:24:25 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: bridge: usage of yaml schema
......................................................................


Patch Set 24:

(3 comments)

https://gerrit.ovirt.org/#/c/54528/24/lib/api/schemaapi.py
File lib/api/schemaapi.py:

PS24, Line 81: params
cannot this be fixed as well?

answering myself: would require million of changes in .yml; can be postponed.


PS24, Line 84: param
nit: param->arg


https://gerrit.ovirt.org/#/c/54528/24/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

PS24, Line 80: defaultArgs
nit: create a fronzenset of default args outside of `for arg`. I hate needless quadratic complexity


-- 
To view, visit https://gerrit.ovirt.org/54528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list