Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...

laravot at redhat.com laravot at redhat.com
Tue May 10 11:46:36 UTC 2016


Liron Aravot has posted comments on this change.

Change subject: sp: allow executing upgradePool even if there is a pending update
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

needs more checking

https://gerrit.ovirt.org/#/c/57188/3/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 439:             self.log.debug("Registering with state change event")
Line 440:             self.domainMonitor.onDomainStateChange.register(
Line 441:                 self._upgradeCallback)
Line 442:             self.log.debug("Running initial domain upgrade threads")
Line 443:             for sdUUID in self._domainsToUpgrade:
need to check about moving this out of the lock scope
Line 444:                 concurrent.thread(target=self._upgradeCallback,
Line 445:                                  args=(sdUUID, True),
Line 446:                                  kwargs={"__securityOverride": True}).start()
Line 447: 


-- 
To view, visit https://gerrit.ovirt.org/57188
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list