Change in vdsm[master]: v2v: get_external_vms return format for KVM images

shavivi at redhat.com shavivi at redhat.com
Tue May 10 06:03:18 UTC 2016


Shahar Havivi has posted comments on this change.

Change subject: v2v: get_external_vms return format for KVM images
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/56912/8/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 946:             d['alias'] = source.get('file')
Line 947:         driver = disk.find('./driver/[@type]')
Line 948:         if driver is not None:
Line 949:             try:
Line 950:                 d["format"] = _convert_disk_format(driver.get('type'))
> What about the schema? we need to document this key and its type.
Schema does have a format.
This is the same structure that we use to import the VM which have the format in the schema (not the video and the graphics due)
Line 951:             except KeyError:
Line 952:                 logging.warning("Disk %s has unsupported format: %r", d,
Line 953:                                 format)
Line 954:         params['disks'].append(d)


-- 
To view, visit https://gerrit.ovirt.org/56912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d4985aafc21e5ff5c11ec7bca71ab9aa5b2cd9d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list