Change in vdsm[master]: volume: Add volumePath setter to manifest.

nsoffer at redhat.com nsoffer at redhat.com
Mon May 9 19:09:05 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: volume: Add volumePath setter to manifest.
......................................................................


volume: Add volumePath setter to manifest.

Fix broken merge volume flow which was introduced at 
commit 038f073df6c40b418119e74826e9b967707588d8 (VolumeMetadata: Move 
volumePath).

Currently when trying to remove a single snapshot,
an exception is being raised, indicating there was an error
during source image manipulation: "can't set attribute".

The propsed fix adds a new setter to volumePath in the volume's manifest.

Change-Id: I4839fcbb3d8263239e2197702f3e1eb984326629
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/57194
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke <alitke at redhat.com>
---
M vdsm/storage/volume.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/57194
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4839fcbb3d8263239e2197702f3e1eb984326629
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list