Change in vdsm[master]: gluster: add gluster heal info verb

rnachimu at redhat.com rnachimu at redhat.com
Mon May 9 14:01:17 UTC 2016


Ramesh N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.ovirt.org/#/c/56738/5/client/vdsClientGluster.py
File client/vdsClientGluster.py:

PS5, Line 751: remoteServer = params.get('remoteServer', '')
> you don't seem to be using remote-server anywhere
Done


https://gerrit.ovirt.org/#/c/56738/5/lib/api/vdsmapi-gluster-schema.json
File lib/api/vdsmapi-gluster-schema.json:

PS5, Line 2215: 'command': {'class': 'GlusterVolume', 'name': 'healInfo'},
              :  'data': {'volumeName': 'str'}}
> you will have to add "returns".
Done


https://gerrit.ovirt.org/#/c/56738/5/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

PS5, Line 1591: return _parseVolumeHealInfo(xmltree)
> can you have another try except block for this call. Because if this fails 
Done


-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list