Change in vdsm[master]: net: OVS Info

edwardh at redhat.com edwardh at redhat.com
Mon May 9 12:58:23 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: OVS Info
......................................................................


Patch Set 24:

(1 comment)

https://gerrit.ovirt.org/#/c/56901/24/tests/network/ovs_info_test.py
File tests/network/ovs_info_test.py:

Line 65:         self.ovs_service.setup()
Line 66:         self.ovsdb = create()
Line 67: 
Line 68:         self.nic1 = Dummy()
Line 69:         self.nic1_name = self.nic1.create()
Note that we may have a cleanup problem here:
If nic2 fails to be created, we will not stop the service and not delete nic1.
Line 70:         self.nic2 = Dummy()
Line 71:         self.nic2_name = self.nic2.create()
Line 72: 
Line 73:         _setup_ovs_network(self.ovsdb, self.nic1_name, self.nic2_name)


-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list