Change in vdsm[master]: net: OVS Info

phoracek at redhat.com phoracek at redhat.com
Mon May 9 12:09:07 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: net: OVS Info
......................................................................


Patch Set 24: Verified+1

(3 comments)

Passed ovs_info_test.py

https://gerrit.ovirt.org/#/c/56901/23/tests/network/ovs_info_test.py
File tests/network/ovs_info_test.py:

PS23, Line 61: 
             :     @ValidateRunningAsRoot
             :     def setUp(self):
             :         self.ovs_service = OvsService()
             :         self.ovs_service.setup()
             :         self.ovsdb = create()
> This block describes one entity creation, placing it in its own helper cont
I moved it to a separate function (it will be used by other tests) and call it from here. No need to clenup created ports, they are removed with bond.


PS23, Line 68:         self.nic1 = Dummy()
             :         self.nic1_name = self.nic1.create()
             :         self.nic2 = Dummy()
             :         self.nic2_name = self.nic2.create()
             : 
             :         _setup_ovs_network(self.ovsdb, self.nic1_n
> Same here
Done


PS23, Line 97: nfo.S
> Ah... nit: consider 'southbound'.
Done


-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list