Change in vdsm[master]: v2v: get_external_vms returns additional video info for kvm ...

shavivi at redhat.com shavivi at redhat.com
Mon May 9 11:51:20 UTC 2016


Shahar Havivi has posted comments on this change.

Change subject: v2v: get_external_vms returns additional video info for kvm images
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57247/1/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 96:     COW_FORMAT: qemuimg.FORMAT.QCOW2,
Line 97:     RAW_FORMAT: qemuimg.FORMAT.RAW,
Line 98: }
Line 99: 
Line 100: STR2FMT = {v: k for k, v in FMT2STR.items()}
> this belongs in the storage patch, not here
right...
Line 101: 
Line 102: # At the moment this is static and it has been introduced to group all the
Line 103: # previous implicit references to the block size in FileVolume. In the future
Line 104: # it will depend on the storage domain.


-- 
To view, visit https://gerrit.ovirt.org/57247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8af456e959fa877b9f8cda8ae1f5d75c32b1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list