Change in vdsm[master]: bridge: usage of yaml schema

danken at redhat.com danken at redhat.com
Mon May 9 10:50:11 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: bridge: usage of yaml schema
......................................................................


Patch Set 23: Code-Review-1

(3 comments)

two nits and one worrying question

https://gerrit.ovirt.org/#/c/54528/23/lib/api/schemaapi.py
File lib/api/schemaapi.py:

PS23, Line 83: param
naming nit: in python (and elsewhere in Vdsm) this is commonly called "arg", not "param")


https://gerrit.ovirt.org/#/c/54528/23/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

Line 82:                     ret = ret + (argobj[arg],)
Line 83:                 else:
Line 84:                     if len(defaultValues) > 0:
Line 85:                         ret = ret + (defaultValues[0],)
Line 86:                 defaultValues = defaultValues[1:]
wouldn't this copy the special-named "no-default" verbatim?
Line 87:             elif arg in argobj:
Line 88:                 ret = ret + (argobj[arg],)
Line 89:         return ret
Line 90: 


PS23, Line 119: class_name
I love pep8, but this change better be in its own patch


-- 
To view, visit https://gerrit.ovirt.org/54528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list