Change in vdsm[ovirt-3.6]: ifcfg: consume bond slaves owned by NetworkManager

osvoboda at redhat.com osvoboda at redhat.com
Sun May 8 12:02:21 UTC 2016


Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/57186

to review the following change.

Change subject: ifcfg: consume bond slaves owned by NetworkManager
......................................................................

ifcfg: consume bond slaves owned by NetworkManager

To let NetworkManager know VDSM wants to consume its devices we
have to create ifcfg files with NM_CONTROLLED=no even for slaves
that are already attached. It will automatically read the ifcfg
files thanks to the previous patch.

Change-Id: I77a600cd3bfddc0da48ae801bb121a8093254ae2
Bug-Url: https://bugzilla.redhat.com/1304509
Signed-off-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/56364
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/57186/1

diff --git a/vdsm/network/configurators/ifcfg.py b/vdsm/network/configurators/ifcfg.py
index 12b0b14..4e7d4ab 100644
--- a/vdsm/network/configurators/ifcfg.py
+++ b/vdsm/network/configurators/ifcfg.py
@@ -156,6 +156,9 @@
                 ifdown(slave.name)  # nics must be down to join a bond
                 self.configApplier.addNic(slave)
                 _exec_ifup(slave.name)
+            else:
+                # Let NetworkManager know that we now own the slave.
+                self.configApplier.addNic(slave)
 
         if bondIfcfgWritten:
             ifdown(bond.name)


-- 
To view, visit https://gerrit.ovirt.org/57186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I77a600cd3bfddc0da48ae801bb121a8093254ae2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list