Change in vdsm[master]: [wip] Adding report_stats to host.api

ybronhei at redhat.com ybronhei at redhat.com
Sun May 8 10:01:46 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: [wip] Adding report_stats to host.api
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56880/2/lib/vdsm/common/host/api.py
File lib/vdsm/common/host/api.py:

Line 201:     report.send('.memory.free', stats['memFree'])
Line 202:     report.send('.memory.swap_total', stats['swapTotal'])
Line 203:     report.send('.memory.swap_free', stats['swapFree'])
Line 204:     report.send('.virt.active_vms', stats['vmActive'])
Line 205:     report.send('.virt.total_vms', stats['vmCount'])
> I think it is good enough as is, we cannot have simpler code :-)
yes it is.. otherwise I need to pass irs and haClient to sampling and from there to here


-- 
To view, visit https://gerrit.ovirt.org/56880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list