Change in vdsm[master]: virt: Don't fail when existingConnAction is unset for a SPIC...

danken at redhat.com danken at redhat.com
Sun May 8 05:59:32 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: Don't fail when existingConnAction is unset for a SPICE device
......................................................................


virt: Don't fail when existingConnAction is unset for a SPICE device

When a ticket for a SPICE device is set, existingConnAction parameter is
sent by Engine as well.  This parameter is used to set `connected'
attribute of <graphics> element.  But setting this parameter when
updating the ticket is basically useless.  It may be actually even
harmful, e.g. when a user sets `connected' attribute value to `keep' in
a Vdsm hook and Engine overrides it to `disconnect' without any good
reason.  See the referenced bug.

This should be fixed on the Engine side.  One approach may be not to
send the parameter at all when updating the SPICE ticket.  However, Vdsm
crashes in such a case.  This patch fixes Vdsm problems when the
parameter is not present, making future changes in Engine possible.

Change-Id: I2fde83ceb994eaafd2aa956d1fa82ce6cb16094c
Bug-Url: https://bugzilla.redhat.com/1060573
Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/56836
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M lib/api/vdsmapi-schema.json
M tests/vmOperationsTests.py
M vdsm/virt/vm.py
3 files changed, 33 insertions(+), 11 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/56836
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2fde83ceb994eaafd2aa956d1fa82ce6cb16094c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list