Change in vdsm[master]: stomp: make sure to handle eagain

danken at redhat.com danken at redhat.com
Sat May 7 15:25:28 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: stomp: make sure to handle eagain
......................................................................


stomp: make sure to handle eagain

Checking asyncore documentation I noticed that we do not process recv
properly. I found that:

Note that recv() may raise socket.error with EAGAIN or EWOULDBLOCK

betterAsyncore code was based on asyncore.dispatcher so the issue was
duplicated. We need to make sure to handle errors properly. We base our
errnos on asynchat which include: EAGAIN, EALREADY, EINPROGRESS,
EWOULDBLOCK.


Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Bug-Url: https://bugzilla.redhat.com/1321325
Related-To: https://bugs.python.org/issue16133
Reviewed-on: https://gerrit.ovirt.org/56997
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list