Change in vdsm[master]: net: OVS netinfo

edwardh at redhat.com edwardh at redhat.com
Thu May 5 20:29:38 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: OVS netinfo
......................................................................


Patch Set 24:

(2 comments)

partial review

https://gerrit.ovirt.org/#/c/56972/24/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:

Line 182:     for bridge, bridge_attrs in six.iteritems(ovs_bridges):
Line 183:         ports = bridge_attrs['ports']
Line 184:         southbound = _get_southbound_port(ports)
Line 185:         for port, port_attrs in six.iteritems(ports):
Line 186:             ip_attrs = port_attrs['ip']
Seems to me that you can move the ip tree here directly, without the need to keep it in OvsInfo.
it also makes sense to name the ip keys as required to avoid the mapping.

So filling port info here from _get_ip_info makes sense to me.
Line 187:             if ip_attrs:
Line 188:                 port_info = {
Line 189:                     'mtu': port_attrs['mtu'],
Line 190:                     'addr': ip_attrs['ipv4addr'],


PS24, Line 199: cfg
Do we need to support the 'cfg' portion? I think we deprecated it.


-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list