Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

mmirecki at redhat.com mmirecki at redhat.com
Thu May 5 15:06:17 UTC 2016


Marcin Mirecki has uploaded a new change for review.

Change subject: net: Network speed reported as -1 if it can not be determined
......................................................................

net: Network speed reported as -1 if it can not be determined

If network speed can not be determined, as is for example the case
with virtio devices, the reported network speed should be -1

Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Bug-Url: https://bugzilla.redhat.com/1322529
Signed-off-by: mirecki <mmirecki at redhat.com>
---
M lib/vdsm/network/netinfo/nics.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/57108/1

diff --git a/lib/vdsm/network/netinfo/nics.py b/lib/vdsm/network/netinfo/nics.py
index 1fd6aaa..07240cf 100644
--- a/lib/vdsm/network/netinfo/nics.py
+++ b/lib/vdsm/network/netinfo/nics.py
@@ -56,8 +56,10 @@
             return _ibHackedSpeed(nic_name)
         else:
             logging.exception('cannot read %s nic speed', nic_name)
+        return -1
     except Exception:
         logging.exception('cannot read %s speed', nic_name)
+        return -1
     return 0
 
 
@@ -68,9 +70,9 @@
     https://bugzilla.redhat.com/show_bug.cgi?id=1101314
     """
     try:
-        return 10000 if drv_name(nic_name) == 'ib_ipoib' else 0
+        return 10000 if drv_name(nic_name) == 'ib_ipoib' else -1
     except IOError:
-        return 0
+        return -1
 
 
 def info(link, paddr):


-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>


More information about the vdsm-patches mailing list