Change in vdsm[master]: Adding reportStats

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu May 5 14:19:42 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: Adding reportStats
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/56880/1/lib/vdsm/host.py
File lib/vdsm/host.py:

Line 446:         # For backwards compatibility, will be removed in the future
Line 447:         stats['haScore'] = stats['haStats']['score']
Line 448: 
Line 449:     stats = hooks.after_get_stats(stats)
Line 450:     _current_stats = stats
> Bad idea, if engine stop calling us, we never update the stats.
You could attempt to report stats faster then engine called. Even if the engine is not talking to vdsm we still need to reportStats.
Line 451:     return stats
Line 452: 
Line 453: 
Line 454: def reportStats():


PS1, Line 457: The format
Why do we need to have it here? It gives me no value. I would prefer to have here the format of a message so we know exactly what is sent.


https://gerrit.ovirt.org/#/c/56880/1/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.py:

PS1, Line 551: reportStats
How can we specify the interval when report is sent?


-- 
To view, visit https://gerrit.ovirt.org/56880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list