Change in vdsm[master]: v2v: Detect VM with snapshots

fromani at redhat.com fromani at redhat.com
Thu May 5 13:43:27 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: v2v: Detect VM with snapshots
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/56574/6/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

PS6, Line 908:     except libvirt.libvirtError as e:
             :         logging.error('Error checking for existing snapshots; %r', e.message)
I prefer if you keep using logging.exception() here.
If we filter out known-not-working scenarios, that will dump only real meaningful stacktraces.


-- 
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list