Change in vdsm[master]: virt: add kernel cmdline reporting

mpolednik at redhat.com mpolednik at redhat.com
Thu May 5 11:32:29 UTC 2016


Martin Polednik has uploaded a new change for review.

Change subject: virt: add kernel cmdline reporting
......................................................................

virt: add kernel cmdline reporting

As we want to control kernel command line from ovirt, we need a way to
let users (and us) see if the changes are successfully applied. We
approach this by reporting kernel command line from /proc/cmdline
without any modifications, allowing for relatively easy debugging.

Name kernelArgs was chosen as we already refer in the same way to guest
kernel arguments.

Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1301104
Signed-off-by: Martin Polednik <mpolednik at redhat.com>
---
M lib/vdsm/osinfo.py
M vdsm/caps.py
2 files changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/57084/1

diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py
index 3b3aeb1..58097c2 100644
--- a/lib/vdsm/osinfo.py
+++ b/lib/vdsm/osinfo.py
@@ -121,6 +121,12 @@
 
 
 @utils.memoized
+def kernel_args():
+    with open('/proc/cmdline', 'r') as f:
+        return f.readline().strip()
+
+
+ at utils.memoized
 def version():
     version = release_name = ''
 
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 66eb245..42bddbe 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -176,6 +176,7 @@
     caps['operatingSystem'] = osinfo.version()
     caps['uuid'] = host.uuid()
     caps['packages2'] = osinfo.package_versions()
+    caps['kernelArgs'] = osinfo.kernel_args()
     caps['emulatedMachines'] = machinetype.emulated_machines(
         cpuarch.effective())
     caps['ISCSIInitiatorName'] = _getIscsiIniName()


-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>


More information about the vdsm-patches mailing list