Change in vdsm[master]: stomp: make sure to handle eagain

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu May 5 09:59:18 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: make sure to handle eagain
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/56997/2//COMMIT_MSG
Commit Message:

Line 11: 
Line 12: Note that recv() may raise socket.error with EAGAIN or EWOULDBLOCK
Line 13: 
Line 14: betterAsyncore code was based on asyncore.dispatcher so the issue was
Line 15: duplicated. We need to make sure to handle this error propely.
> Please mention we handle now the same errors handled by asynchat.
Done
Line 16: 
Line 17: 
Line 18: Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Line 19: Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>


https://gerrit.ovirt.org/#/c/56997/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 116
Line 117
Line 118
Line 119
Line 120
> In another patch we need to copy this constant into our code, we don't want
Agreed


-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list