Change in vdsm[master]: Move host stats dict creation from API.py to host module

mpolednik at redhat.com mpolednik at redhat.com
Thu May 5 08:22:22 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: Move host stats dict creation from API.py to host module
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

Thanks for simplifying the PS, it's way more reasonable to review now. Unfortunately, I believe that moving the 2 commented functions to top level of VDSM library is not really a code improvement and it should either stay out of the library, or in a place like api/ that would handle all RPC formatting.

https://gerrit.ovirt.org/#/c/56874/6/lib/vdsm/host.py
File lib/vdsm/host.py:

PS6, Line 78: def getStats(irs, cif, haClient):
I don't believe this belongs here: it is more of an API facing function that is supposed to format the information for API instead of computing it. We're in top-level of VDSM library, where the functions should focus on being useful throughout VDSM instead of out-of-vdsm communication.


PS6, Line 190: def _getHaInfo(haClient):
Similar to getStats.


-- 
To view, visit https://gerrit.ovirt.org/56874
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I626a673c429d486ac78b309c2f31cb58af8852b2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list