Change in vdsm[master]: v2v: get_external_vms return format for KVM images

shavivi at redhat.com shavivi at redhat.com
Thu May 5 07:23:18 UTC 2016


Shahar Havivi has posted comments on this change.

Change subject: v2v: get_external_vms return format for KVM images
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56912/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 935:         driver = disk.find('./driver/[@type]')
Line 936:         if driver is not None:
Line 937:             format = driver.get('type')
Line 938:             if format.lower().startswith('qcow'):
Line 939:                 d['format'] = 'cow'
> You must use vdsm public constants - there is no way that vdsm will publish
sure,
I did add str2fmt...
Will send it in the next patch
Line 940:         params['disks'].append(d)
Line 941: 
Line 942: 
Line 943: def _add_networks(root, params):


-- 
To view, visit https://gerrit.ovirt.org/56912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d4985aafc21e5ff5c11ec7bca71ab9aa5b2cd9d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list