Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

nsoffer at redhat.com nsoffer at redhat.com
Wed May 4 18:41:12 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: tests: Use MonkeyPatchScope to inject failures
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/56936/2/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:

Line 218:         with self.fake_env() as env:
Line 219:             artifacts = env.sd_manifest.get_volume_artifacts(
Line 220:                 self.img_id, self.vol_id)
Line 221:             with MonkeyPatchScope([
Line 222:                 [artifacts, '_create_volume_file', failure]
We don't need to monkeypatch this object, we are throwing it away on the end of the test.

Can we monkey patch the object creating the file - manifest.oop.xxx?
Line 223:             ]):
Line 224:                 self.assertRaises(ExpectedFailure, artifacts.create,
Line 225:                                   *BASE_RAW_PARAMS)
Line 226:             self.validate_new_image_path(artifacts,


-- 
To view, visit https://gerrit.ovirt.org/56936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceed070c2da36460f6aa60a72f079d2e185da6a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list