Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

igoihman at redhat.com igoihman at redhat.com
Wed May 4 16:34:12 UTC 2016


Irit Goihman has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
......................................................................


Patch Set 15: Verified+1

(6 comments)

https://gerrit.ovirt.org/#/c/53214/13/lib/vdsm/module_loader.py
File lib/vdsm/module_loader.py:

PS13, Line 34: 
             : 
> Can we please control this with a flag?
I want a more general behavior so I removed this part from the function


https://gerrit.ovirt.org/#/c/53214/14/lib/vdsm/module_loader.py
File lib/vdsm/module_loader.py:

Line 26: def load_modules(pkg_name):
Line 27:     modules = {}
Line 28:     for _, module_name, _ in pkgutil.iter_modules([pkg_name.__path__[0]]):
Line 29:         modules[module_name] = importlib.import_module(
Line 30:             '{}.{}'.format(pkg_name.__name__, module_name))
> remove comment .. and prints..
this is a draft version


Line 32
Line 33
Line 34
Line 35
Line 36
> optional?
Done


https://gerrit.ovirt.org/#/c/53214/13/tests/module_loader_test.py
File tests/module_loader_test.py:

PS13, Line 40:             utils.touchFile(os.path.join(path, '__init__.py'))
             :             sys.path.append(os.path.dirname(path))
             :             yield importlib.import_module(os.path.basename(path))
             : 
> What about moving this to a separated contextmanager?
Done


https://gerrit.ovirt.org/#/c/53214/13/vdsm.spec.in
File vdsm.spec.in:

Line 1191
Line 1192
Line 1193
Line 1194
Line 1195
> Please do not fix this here, it will cause uneeded conflicts with other cha
Done


Line 1191
Line 1192
Line 1193
Line 1194
Line 1195
> I agree, this change is not related to this patch.
Done


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list