Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

ybronhei at redhat.com ybronhei at redhat.com
Wed May 4 16:10:34 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
......................................................................


Patch Set 14:

(3 comments)

https://gerrit.ovirt.org/#/c/53214/14/lib/vdsm/module_loader.py
File lib/vdsm/module_loader.py:

Line 26: 
Line 27: 
Line 28: def load_modules(pkg_name):
Line 29:     print(sys.path)
Line 30: #    sys.path.append(os.path.dirname(pkg_path))
remove comment .. and prints..
Line 31:     modules = {}
Line 32:     for _, module_name, _ in pkgutil.iter_modules([pkg_name.__path__[0]]):
Line 33:         modules[module_name] = importlib.import_module(
Line 34:             '{}.{}'.format(pkg_name.__name__, module_name))


Line 32:     for _, module_name, _ in pkgutil.iter_modules([pkg_name.__path__[0]]):
Line 33:         modules[module_name] = importlib.import_module(
Line 34:             '{}.{}'.format(pkg_name.__name__, module_name))
Line 35:         if not hasattr(modules[module_name], 'name'):
Line 36:             setattr(modules[module_name], 'name', module_name)
optional?


https://gerrit.ovirt.org/#/c/53214/14/vdsm.spec.in
File vdsm.spec.in:

Line 1121: %{python_sitelib}/%{vdsm_name}/libvirtconnection.py*
Line 1122: %{python_sitelib}/%{vdsm_name}/logUtils.py*
Line 1123: %{python_sitelib}/%{vdsm_name}/m2cutils.py*
Line 1124: %{python_sitelib}/%{vdsm_name}/machinetype.py*
Line 1125: %{python_sitelib}/%{vdsm_name}/momIF.py*
should be here
Line 1126: %{python_sitelib}/%{vdsm_name}/netinfo/__init__.py*
Line 1127: %{python_sitelib}/%{vdsm_name}/netinfo/addresses.py*
Line 1128: %{python_sitelib}/%{vdsm_name}/netinfo/bonding.py*
Line 1129: %{python_sitelib}/%{vdsm_name}/netinfo/bridges.py*


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list