Change in vdsm[master]: net: Move netinfo under vdsm.network

osvoboda at redhat.com osvoboda at redhat.com
Wed May 4 15:07:51 UTC 2016


Ondřej Svoboda has posted comments on this change.

Change subject: net: Move netinfo under vdsm.network
......................................................................


Patch Set 2:

(1 comment)

vdsmnetinfodir could be removed.

https://gerrit.ovirt.org/#/c/56713/2/configure.ac
File configure.ac:

Line 220: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
Line 221: AC_SUBST([vdsmrepo], ['/rhev/data-center'])
Line 222: AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm'])
Line 223: AC_SUBST([vdsminfradir], ['${vdsmpylibdir}/infra'])
Line 224: AC_SUBST([vdsmnetinfodir], ['${vdsmpylibdir}/network/netinfo'])
> I have no idea, not even sure what it is used for.
Well, git grep shows no use of it, unlike of vdsminfradir, which appears as $(vdsminfradir) in 4 other makefiles.

So we could as well lose the directive altogether.

If anything -- if we wanted to introduce a constant and use it in other places -- one referring to the network package would be a better candidate.
Line 225: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
Line 226: AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators'])
Line 227: AC_SUBST([vdsmtestsdir], ['${datarootdir}/vdsm/tests'])
Line 228: 


-- 
To view, visit https://gerrit.ovirt.org/56713
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia02e5f79e093067789659e414b595aa4e3d5a62e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list