Change in vdsm[master]: virt: Don't fail when existingConnAction is unset for a SPIC...

fromani at redhat.com fromani at redhat.com
Wed May 4 07:21:56 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Don't fail when existingConnAction is unset for a SPICE device
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

Indeed the tests are starting to become too complex. We should oimprove this, but in a future patch set. This patch is good enough I believe.

https://gerrit.ovirt.org/#/c/56836/3/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 7402: # @password:            The desired connection password
Line 7403: #
Line 7404: # @ttl:                 The number of seconds before the password expires
Line 7405: #
Line 7406: # @existingConnAction:  #optional Indicate what to do with any existing connections
please add a line like

  (made optional in version 4.1y.z)

there are other examples in the schema
Line 7407: #
Line 7408: # @params:              Arbitrary key:val pairs that will be passed to hooks
Line 7409: #
Line 7410: # Since: 4.15.0


https://gerrit.ovirt.org/#/c/56836/3/tests/vmOperationsTests.py
File tests/vmOperationsTests.py:

PS3, Line 146:         graphics_params = {k: v for k, v in _GRAPHICS_DEVICE_PARAMS.items()
             :                            if k != 'existingConnAction'}
silly nit: I think

  graphic_params = dict(_GRAPHICS_DEVICE_PARAMS)
  del graphic_params['existingConnAction']

is a bit clearer, but surely *not* worth resubmit for this reason. Please just consider this for next patches.


-- 
To view, visit https://gerrit.ovirt.org/56836
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fde83ceb994eaafd2aa956d1fa82ce6cb16094c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list