Change in vdsm[master]: virt: delay appendFeatures and appendClock

fromani at redhat.com fromani at redhat.com
Wed May 4 07:02:13 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: delay appendFeatures and appendClock
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

partial review. At first glance looks like a good addition anyway, more consistent with new setup/teardown code we are adding. Will do another pass later for deeper review

https://gerrit.ovirt.org/#/c/56974/1//COMMIT_MSG
Commit Message:

Line 11: bottom of domain XML building to have all devices setup by the time we
Line 12: get there.
Line 13: 
Line 14: That means, flags/timers depending on device configuration can
Line 15: access the created device objects.
this could be a good idea anyway
Line 16: 
Line 17: Change-Id: I4c3a719b57978a7f7adc0f0845c706e3c525574b


-- 
To view, visit https://gerrit.ovirt.org/56974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c3a719b57978a7f7adc0f0845c706e3c525574b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list