Change in vdsm[master]: net: don't handle OVS networks in netinfo

edwardh at redhat.com edwardh at redhat.com
Wed May 4 06:12:00 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: don't handle OVS networks in netinfo
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Just a nit

https://gerrit.ovirt.org/#/c/56838/2/lib/vdsm/netinfo/__init__.py
File lib/vdsm/netinfo/__init__.py:

PS2, Line 54:             virtualport = xml.find('.//virtualport')
            :             if (virtualport is not None and
            :                     virtualport.get('type') == 'openvswitch'):
Seems to fit a separate func: _is_openvswitch(xml)

It is unfortunate that we cannot filter legacy bridge config directly, leaving us to do a negative filter.

It actually belongs to a network libvirt module/package.
We should move the existing configurator/libvirt to network/libvirt and add there all network libvirt related handlers.


-- 
To view, visit https://gerrit.ovirt.org/56838
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie733d39efa0fd40a81d3111d55fa19dde9a3c1b6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list