Change in vdsm[master]: tests: Share failure function

alitke at redhat.com alitke at redhat.com
Mon May 2 14:20:42 UTC 2016


Adam Litke has posted comments on this change.

Change subject: tests: Share failure function
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/56863/1/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:

Line 32
Line 33
Line 34
Line 35
Line 36
> I would put it here:
Done


Line 47:         self.img_id = str(uuid.uuid4())
Line 48:         self.vol_id = str(uuid.uuid4())
Line 49: 
Line 50:     def failure(*args, **kwargs):
Line 51:         raise ExpectedFailure()
> Why do we need a method? this can be a function in the module.
Done
Line 52: 
Line 53:     def test_state_missing(self):
Line 54:         with self.fake_env() as env:
Line 55:             artifacts = env.sd_manifest.get_volume_artifacts(


-- 
To view, visit https://gerrit.ovirt.org/56863
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9957eed4333d89071b91ff3f842eafd7469c841
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list