Change in vdsm[master]: rpc: Add test for 'int' parameters in Bridge

mbetak at redhat.com mbetak at redhat.com
Mon May 2 13:35:11 UTC 2016


Martin Betak has posted comments on this change.

Change subject: rpc: Add test for 'int' parameters in Bridge
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56884/1/tests/bridgeTests.py
File tests/bridgeTests.py:

Line 155: 
Line 156:         self.assertEquals(e.exception.code, 100)
Line 157: 
Line 158:     @MonkeyPatch(DynamicBridge, '_get_api_instance', _get_api_instance)
Line 159:     def testMethodWithIntParam(self):
> Please check fenceNode you could check (value/type) it in similar way and h
Done
Line 160:         bridge = DynamicBridge()
Line 161: 
Line 162:         params = {"vmID": "773adfc7-10d4-4e60-b700-3272ee1871f9",
Line 163:                   "params": {"vmID": "773adfc7-10d4-4e60-b700-3272ee1871f9"},


-- 
To view, visit https://gerrit.ovirt.org/56884
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8a2672c53411bed1ac711fffccb543bcfb16024
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list